Skip to content

Media library 23562#10832

Closed
joedolson wants to merge 18 commits intoWordPress:trunkfrom
joedolson:media-library-23562
Closed

Media library 23562#10832
joedolson wants to merge 18 commits intoWordPress:trunkfrom
joedolson:media-library-23562

Conversation

@joedolson
Copy link
Contributor

This pull request resolves the two major issues in the Media Library modal that block voice command users from being able to use the library, as described in the ticket.

Trac ticket: https://core.trac.wordpress.org/ticket/23562


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Changes the current filter heading to be hidden using .screen-reader-text, changes the labels to be visible. Adds wrapper around the labels & inputs for filters for styling, updates styling to adapt for visible labels.
Allows voice command users to select images in the media library.
@github-actions
Copy link

github-actions bot commented Jan 31, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@joedolson
Copy link
Contributor Author

Practically speaking, I'd like to have this extend to other list table views, but I think that's overreach for this PR.

@joedolson
Copy link
Contributor Author

Screenshots, after:

Screenshot 2026-02-25 at 1 48 25 PM Screenshot 2026-02-25 at 1 47 43 PM Screenshot 2026-02-25 at 1 47 19 PM Screenshot 2026-02-25 at 1 46 23 PM Screenshot 2026-02-25 at 1 55 35 PM Screenshot 2026-02-25 at 1 48 46 PM

@joedolson
Copy link
Contributor Author

Notes:

  • The misalignment of the menu button is unrelated; see core 64726.
  • The overflowing filters being hidden behind the list of images in smaller viewports is a pre-existing problem which I did not choose to fix as part of this set of changes. I did adjust layouts so that the fact there is an overflow is visible, and made the overflow scrollable so it is possible to use.

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61757
GitHub commit: 84caa24

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants